Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10660003: Add xvfb dep since we use it in run_tests.sh (Closed)

Created:
8 years, 6 months ago by Isaac (away)
Modified:
8 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add xvfb dep since we use it in run_tests.sh - and minor cleanup to script BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M build/install-build-deps-android.sh View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Isaac (away)
8 years, 6 months ago (2012-06-22 20:49:42 UTC) #1
nilesh
On 2012/06/22 20:49:42, Isaac wrote: LGTM
8 years, 6 months ago (2012-06-22 20:54:39 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-06-22 23:05:04 UTC) #3
Isaac (away)
Can haz CQ approval
8 years, 6 months ago (2012-06-22 23:05:42 UTC) #4
Yaron
lgtm
8 years, 6 months ago (2012-06-22 23:07:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/10660003/1
8 years, 6 months ago (2012-06-22 23:08:04 UTC) #6
commit-bot: I haz the power
Change committed as 143749
8 years, 6 months ago (2012-06-22 23:58:59 UTC) #7
John Grabowski
We only use xvfb if using the emulator, which we don't do. But this is ...
8 years, 6 months ago (2012-06-26 06:58:04 UTC) #8
Isaac (away)
8 years, 6 months ago (2012-06-26 07:21:00 UTC) #9
We are calling run_tests.sh with '--xfvb', so the tests currently fail on
systems without this dep.  If we remove that flag we can remove these deps too.

Powered by Google App Engine
This is Rietveld 408576698