Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10659033: Get rid of DOMWrapperBase and DOMTypeBase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/scanner/source_list.dart ('k') | lib/dom/src/DOMWrapperBase.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index 7035599f49d23e38b803560364416d87c0f992c1..db01ddd7654b5a3047fffd5599e177f4cf0bf5f5 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -413,13 +413,15 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
return self._html_system.DartType(idl_type)
def _BaseClassName(self):
+ root_class = 'NativeFieldWrapperClass1'
+
if not self._interface.parents:
- return '_DOMWrapperBase'
+ return root_class
supertype = self._interface.parents[0].type.id
if IsPureInterface(supertype): # The class is a root.
- return '_DOMWrapperBase'
+ return root_class
# FIXME: We're currently injecting List<..> and EventTarget as
# supertypes in dart.idl. We should annotate/preserve as
@@ -427,7 +429,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
# inherit, but not the classes.
# List methods are injected in AddIndexer.
if IsDartListType(supertype) or IsDartCollectionType(supertype):
- return '_DOMWrapperBase'
+ return root_class
if supertype == 'EventTarget':
# Most implementors of EventTarget specify the EventListener operations
@@ -437,7 +439,7 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
# Applies to MessagePort.
if not [op for op in self._interface.operations if op.id == 'addEventListener']:
return self._ImplClassName(supertype)
- return '_DOMWrapperBase'
+ return root_class
return self._ImplClassName(supertype)
« no previous file with comments | « lib/compiler/implementation/scanner/source_list.dart ('k') | lib/dom/src/DOMWrapperBase.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698