Issue 10659011: Correctly throw reference error in strict mode with ICs disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10659011: Correctly throw reference error in strict mode with ICs disabled. (Closed)

Created:
8 years, 6 months ago by Yang

Modified:
8 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Correctly throw reference error in strict mode with ICs disabled. R=jkummerow@chromium.org BUG=v8:2119 TEST=regress/regress-2119.js Committed: https://code.google.com/p/v8/source/detail?r=11923

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -6 lines)			Patch
	M	src/ic.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-2119.js	View		1 chunk	+7 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 6 months ago (2012-06-25 13:26:43 UTC) #2

LGTM with nit.

https://chromiumcodereview.appspot.com/10659011/diff/1/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-2119.js (right):

https://chromiumcodereview.appspot.com/10659011/diff/1/test/mjsunit/regress/r...
test/mjsunit/regress/regress-2119.js:28: // Flags: --nouse-ic --use-strict
I'd prefer to have the "use strict" magic string in the function instead of
passing in a flag.

Expand Messages | Collapse Messages