Issue 10659009: Merge 121072 - REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffset…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10659009: Merge 121072 - REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffset… (Closed)

Created:
8 years, 6 months ago by Julien - ping for review

Modified:
8 years, 6 months ago

Reviewers:
jchaffraix

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Visibility:
Public.

More Reviews

Description

Merge 121072 - REGRESSION(r116446): Crash in RenderBoxModelObject::adjustedPositionRelativeToOffsetParent https://bugs.webkit.org/show_bug.cgi?id=89785 Reviewed by Abhishek Arya. Source/WebCore: Test: fullscreen/full-screen-crash-offsetLeft.html * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent): Added a NULL-check for parent() as it can be NULL in fullscreen mode. Also updated a stale comment while touching the code. LayoutTests: * fullscreen/full-screen-crash-offsetLeft-expected.html: Added. * fullscreen/full-screen-crash-offsetLeft.html: Added. TBR=jchaffraix@webkit.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121081

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -1 line)			Patch
A +	LayoutTests/fullscreen/full-screen-crash-offsetLeft.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/fullscreen/full-screen-crash-offsetLeft-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/rendering/RenderBoxModelObject.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages