Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: runtime/vm/code_generator_ia32.cc

Issue 10659005: Implement type cast in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/ast.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_ia32.cc
===================================================================
--- runtime/vm/code_generator_ia32.cc (revision 9069)
+++ runtime/vm/code_generator_ia32.cc (working copy)
@@ -1879,7 +1879,7 @@
node->left()->Visit(this);
// The instanceof operator needs special handling.
- if (Token::IsInstanceofOperator(node->kind())) {
+ if (Token::IsTypeTestOperator(node->kind())) {
__ popl(EAX); // Left operand.
ASSERT(node->right()->IsTypeNode());
GenerateInstanceOf(node->id(),
@@ -1893,6 +1893,11 @@
return;
}
+ if (Token::IsTypeCastOperator(node->kind())) {
+ // This code generator is not maintained anymore.
+ UNIMPLEMENTED();
+ }
+
node->right()->Visit(this);
// Both left and right values on stack.
« no previous file with comments | « runtime/vm/ast.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698