Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 10659003: ash: Add launcher overflow bubble. (Closed)

Created:
8 years, 6 months ago by xiyuan
Modified:
8 years, 5 months ago
CC:
chromium-reviews, tfarina, alicet1, sadrul, msw+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

ash: Add launcher overflow bubble. - Host a LauncherView in bubble to display overflown items; - Mouse wheel and two-finger scroll to scroll the LauncherView in bubble in case overflow bubble is overflown; - Fit bubble when items are added/removed; - Keep launcher bar on screen when the bubble is shown; BUG=128054 TEST=Verify launcher overflown items are in a bubble instead of menu. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146460

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase + fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -69 lines) Patch
M ash/ash.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ash/launcher/launcher.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ash/launcher/launcher.cc View 1 3 chunks +7 lines, -1 line 0 comments Download
M ash/launcher/launcher_view.h View 1 9 chunks +27 lines, -3 lines 0 comments Download
M ash/launcher/launcher_view.cc View 1 15 chunks +77 lines, -65 lines 0 comments Download
A ash/launcher/overflow_bubble.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A ash/launcher/overflow_bubble.cc View 1 2 1 chunk +291 lines, -0 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
8 years, 5 months ago (2012-07-11 20:47:29 UTC) #1
Ben Goodger (Google)
LGTM. We should support dragging out of the overflow and onto the launcher to reorder. ...
8 years, 5 months ago (2012-07-12 03:08:27 UTC) #2
xiyuan
On 2012/07/12 03:08:27, Ben Goodger (Google) wrote: > LGTM. > > We should support dragging ...
8 years, 5 months ago (2012-07-12 16:31:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10659003/10010
8 years, 5 months ago (2012-07-12 20:03:14 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-12 22:10:33 UTC) #5
Change committed as 146460

Powered by Google App Engine
This is Rietveld 408576698