Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: ppapi/c/trusted/ppb_browser_font_trusted.h

Issue 10658037: Implement right-to-left text rendering in Pepper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: <PATCH DESCRIPTION HERE> Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/dev/ppb_font_dev.h ('k') | ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/trusted/ppb_browser_font_trusted.h
diff --git a/ppapi/c/trusted/ppb_browser_font_trusted.h b/ppapi/c/trusted/ppb_browser_font_trusted.h
index 080d0247e9fdfb91625b16c000a6a5c16a51a153..c16a153442fbc8524bfb6b52011b0886726b5b52 100644
--- a/ppapi/c/trusted/ppb_browser_font_trusted.h
+++ b/ppapi/c/trusted/ppb_browser_font_trusted.h
@@ -4,7 +4,7 @@
*/
/* From trusted/ppb_browser_font_trusted.idl,
- * modified Tue Feb 14 08:45:20 2012.
+ * modified Wed Jun 27 14:43:20 2012.
*/
#ifndef PPAPI_C_TRUSTED_PPB_BROWSER_FONT_TRUSTED_H_
@@ -252,6 +252,10 @@ struct PPB_BrowserFont_Trusted_1_0 {
* the string. This handles complex scripts such as Arabic, where characters
* may be combined or replaced depending on the context. Returns (uint32)-1
* on failure.
+ *
+ * TODO(brettw) this function may be broken. See the CharPosRTL test. It
+ * seems to tell you "insertion point" rather than painting position. This
+ * is useful but maybe not what we intended here.
*/
uint32_t (*CharacterOffsetForPixel)(
PP_Resource font,
« no previous file with comments | « ppapi/c/dev/ppb_font_dev.h ('k') | ppapi/shared_impl/private/ppb_browser_font_trusted_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698