Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: ppapi/api/trusted/ppb_browser_font_trusted.idl

Issue 10658037: Implement right-to-left text rendering in Pepper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: <PATCH DESCRIPTION HERE> Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/api/dev/ppb_font_dev.idl ('k') | ppapi/c/dev/ppb_font_dev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/api/trusted/ppb_browser_font_trusted.idl
diff --git a/ppapi/api/trusted/ppb_browser_font_trusted.idl b/ppapi/api/trusted/ppb_browser_font_trusted.idl
index 7c0c633f344286c7048f057d64295fff3f5f9d8b..79cee8cefd149f5969dbec3ea6cc233f3d3efb8c 100644
--- a/ppapi/api/trusted/ppb_browser_font_trusted.idl
+++ b/ppapi/api/trusted/ppb_browser_font_trusted.idl
@@ -237,6 +237,10 @@ interface PPB_BrowserFont_Trusted {
* the string. This handles complex scripts such as Arabic, where characters
* may be combined or replaced depending on the context. Returns (uint32)-1
* on failure.
+ *
+ * TODO(brettw) this function may be broken. See the CharPosRTL test. It
+ * seems to tell you "insertion point" rather than painting position. This
+ * is useful but maybe not what we intended here.
*/
uint32_t CharacterOffsetForPixel(
[in] PP_Resource font,
« no previous file with comments | « ppapi/api/dev/ppb_font_dev.idl ('k') | ppapi/c/dev/ppb_font_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698