Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: webkit/fileapi/isolated_context.h

Issue 10658029: Revert 144115 - Manage IsolatedContext with reference counts (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_unittest.cc ('k') | webkit/fileapi/isolated_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/isolated_context.h
===================================================================
--- webkit/fileapi/isolated_context.h (revision 144132)
+++ webkit/fileapi/isolated_context.h (working copy)
@@ -54,20 +54,8 @@
std::string RegisterIsolatedFileSystem(const std::set<FilePath>& fileset);
// Revokes filesystem specified by the given filesystem_id.
- // Note that this revokes the filesystem no matter how many references it has.
- // It is ok to call this on the filesystem that has been already deleted
- // (if its reference count had reached 0).
void RevokeIsolatedFileSystem(const std::string& filesystem_id);
- // Adds a reference to a filesystem specified by the given filesystem_id.
- void AddReference(const std::string& filesystem_id);
-
- // Removes a reference to a filesystem specified by the given filesystem_id.
- // If the reference count reaches 0 the isolated context gets destroyed.
- // It is ok to call this on the filesystem that has been already deleted
- // (e.g. by RevokeIsolatedFileSystem).
- void RemoveReference(const std::string& filesystem_id);
-
// Cracks the given |virtual_path| (which should look like
// "/<filesystem_id>/<relative_path>") and populates the |filesystem_id|
// and |platform_path| if the embedded <filesystem_id> is registerred
@@ -114,10 +102,6 @@
IsolatedContext();
~IsolatedContext();
- // Removes the given filesystem without locking.
- // (The caller must hold a lock)
- void RevokeWithoutLocking(const std::string& filesystem_id);
-
// Returns a new filesystem_id. Called with lock.
std::string GetNewFileSystemId() const;
@@ -134,10 +118,6 @@
// security policy manager, e.g. ChildProcessSecurityPolicy.
std::set<std::string> writable_ids_;
- // Reference counts. Note that an isolated filesystem is created with ref==0.
- // and will get deleted when the ref count reaches <=0.
- std::map<std::string, int> ref_counts_;
-
DISALLOW_COPY_AND_ASSIGN(IsolatedContext);
};
« no previous file with comments | « content/browser/renderer_host/render_view_host_unittest.cc ('k') | webkit/fileapi/isolated_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698