Issue 10658014: Fix Harmony Maps and WeakMaps for undefined values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10658014: Fix Harmony Maps and WeakMaps for undefined values. (Closed)

Created:
8 years, 6 months ago by Michael Starzinger

Modified:
8 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Harmony Maps and WeakMaps for undefined values. R=rossberg@chromium.org BUG=chromium:132744 TEST=mjsunit/harmony/collections Committed: https://code.google.com/p/v8/source/detail?r=11924

Patch Set 2 : Adapted unit test case. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -40 lines)			Patch
M	src/collection.js	View		5 chunks	+5 lines, -15 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View		3 chunks	+60 lines, -6 lines	0 comments	Download
M	test/cctest/test-dictionary.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	test/mjsunit/harmony/collections.js	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with nit. https://chromiumcodereview.appspot.com/10658014/diff/1/src/runtime.cc File src/runtime.cc (right): https://chromiumcodereview.appspot.com/10658014/diff/1/src/runtime.cc#newcode798 src/runtime.cc:798: CONVERT_ARG_HANDLE_CHECKED(Object, key, 1); Why that change? ...

8 years, 6 months ago (2012-06-25 12:39:32 UTC) #2

Michael Starzinger

8 years, 6 months ago (2012-06-25 13:10:46 UTC) #3

https://chromiumcodereview.appspot.com/10658014/diff/1/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/10658014/diff/1/src/runtime.cc#newcode798
src/runtime.cc:798: CONVERT_ARG_HANDLE_CHECKED(Object, key, 1);
On 2012/06/25 12:39:32, rossberg wrote:
> Why that change? Using that macro is redundant when the type is Object. (Same
> below)

That is in line with one of Sven's refactorings and I just wanted to continue
what he started. See the following CLs for more context. As discussed offline,
I'll keep the change.

https://chromiumcodereview.appspot.com/9395075
https://chromiumcodereview.appspot.com/9616016

Expand Messages | Collapse Messages

Issue 10658014: Fix Harmony Maps and WeakMaps for undefined values. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Adapted unit test case. #

Messages