- Document the store barrier.

runtime/vm/assembler_ia32.cc

Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc	(revision 9050)
+++ runtime/vm/assembler_ia32.cc	(working copy)
@@ -1384,14 +1384,23 @@
 }
 
 
+// Destroys the value register.
 void Assembler::StoreIntoObjectFilter(Register object,
                                       Register value,
                                       Label* no_update) {
-  andl(value, Immediate(0x5));
+  // For the value we are only interested in the new/old bit and the tag bit.
+  andl(value, Immediate(kNewObjectAlignmentOffset | kHeapObjectTag));
+  // Shift the tag bit into the carry.
   shrl(value, Immediate(1));
+  // Add the tag bits together, if the value is not a Smi the addition will
+  // overflow into the next bit, leaving us with a zero low bit.
   adcl(value, object);
-  andl(value, Immediate(0x7));
-  cmpl(value, Immediate(0x4));
+  // Mask out higher, uninteresting bits which were polluted by dest.
+  andl(value, Immediate(kObjectAlignment - 1));
+  // Compare with the expected bit pattern.
+  cmpl(value, Immediate(
+      (kNewObjectAlignmentOffset >> 1) + kHeapObjectTag +
+      kOldObjectAlignmentOffset + kHeapObjectTag));
   j(NOT_ZERO, no_update, Assembler::kNearJump);
 }