Stop using ParameterAdapter<String> in generated code.

lib/dom/scripts/generator.py

 #!/usr/bin/python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 """This module provides shared functionality for systems to generate
 Dart APIs from the IDL database."""
 
 import copy
 import re
@@ skipping 637 matching lines @@
 class PrimitiveIDLTypeInfo(IDLTypeInfo):
   def __init__(self, idl_type, dart_type, native_type=None,
                webcore_getter_name='getAttribute',
                webcore_setter_name='setAttribute'):
     super(PrimitiveIDLTypeInfo, self).__init__(idl_type, dart_type=dart_type,
         native_type=native_type)
     self._webcore_getter_name = webcore_getter_name
     self._webcore_setter_name = webcore_setter_name
 
   def emit_to_native(self, emitter, idl_node, name, handle, interface_name):
-    if self.native_type() == 'String':
-      arguments = [handle]
-      if idl_node.ext_attrs.get('Optional') == 'DefaultIsNullString':
-        arguments.append('DartUtilities::ConvertNullToDefaultValue')
-      emitter.Emit(
-          '        const ParameterAdapter<String> $NAME($ARGUMENTS);\n'
-          '        if (!$NAME.conversionSuccessful()) {\n'
-          '            exception = $NAME.exception();\n'
-          '            goto fail;\n'
-          '        }\n',
-          NAME=name,
-          ARGUMENTS=', '.join(arguments))
-    else:
-      type = self.native_type()
-      if type == 'SerializedScriptValue':
-        type = 'RefPtr<%s>' % type
-      emitter.Emit(
-          '\n'
-          '        $TYPE $NAME = DartUtilities::dartTo$CAPITALIZED_TYPE($HANDLE, exception);\n'
-          '        if (exception)\n'
-          '            goto fail;\n',
-          TYPE=type,
-          NAME=name,
-          CAPITALIZED_TYPE=self._capitalized_native_type(),
-          HANDLE=handle)
+    function_name = 'dartTo%s' % self._capitalized_native_type()
+    if idl_node.ext_attrs.get('Optional') == 'DefaultIsNullString':
+      function_name += 'WithNullCheck'
+    type = self.native_type()
+    if type == 'SerializedScriptValue':
+      type = 'RefPtr<%s>' % type
+    if type == 'String':
+      type = 'DartStringAdapter'
+    emitter.Emit(
+        '\n'
+        '        $TYPE $NAME = DartUtilities::$FUNCTION_NAME($HANDLE, exception);\n'
+        '        if (exception)\n'
+        '            goto fail;\n',
+        TYPE=type,
+        NAME=name,
+        FUNCTION_NAME=function_name,
+        HANDLE=handle)
     return name
 
   def parameter_type(self):
     if self.native_type() == 'String':
       return 'const String&'
     return self.native_type()
 
   def conversion_includes(self):
     return []
 
@@ skipping 154 matching lines @@
 
   match = re.match(r'sequence<(\w+)>$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
 
   match = re.match(r'(\w+)\[\]$', idl_type_name)
   if match:
     return SequenceIDLTypeInfo(idl_type_name, GetIDLTypeInfo(match.group(1)))
 
   return IDLTypeInfo(idl_type_name)