Silence adb command output by default

Silence adb command output by default

- Cherrypick from downstream
  https://gerrit-int.chromium.org/#/c/23445/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152449

[bulach, 2012-06-25 09:47:51]

http://codereview.chromium.org/10657017/diff/2001/build/android/android_comma...
File build/android/android_commands.py (right):

http://codereview.chromium.org/10657017/diff/2001/build/android/android_comma...
build/android/android_commands.py:469: path, self.RunShellCommand('ls -lR %s' %
path, log_result=False),
long story super short: in the past, we had various problems that were only
caught with the logs. things like parsing the output of a given command not
being robust enough to deal with unexpected output or errors, etc..

I think we're now in a much better situation, and overall all the parsers and
callers for RunShellCommand are much more reliable...

my suggestion would be: instead of sprinkling these with log_result=False, let's
make the default False, and then only the lines that actually need, would turn
it on...

since this is such a high impact change though, I'd suggest doing it downstream
first, wait a few days, then upstream..
(and yes, I know it's locked down :) but unfortunately we don't have yet the
same coverage level yet for such broad changes upstream first..).

wdyt?

[Isaac (away), 2012-08-17 02:37:53]

OK I changed this patch to not log by default.  ptal

[nilesh, 2012-08-20 16:25:47]

On 2012/08/18 03:07:47, Isaac wrote:

LGTM

[commit-bot: I haz the power, 2012-08-20 17:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10657017/9001

[commit-bot: I haz the power, 2012-08-20 21:40:10]

Try job failure for 10657017-9001 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-20 22:24:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10657017/9001

[commit-bot: I haz the power, 2012-08-21 00:41:21]

Change committed as 152449