Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10657011: IndexedDB: Remove IPC plumbing for obsolete property accessors. (Closed)

Created:
8 years, 6 months ago by jsbell
Modified:
8 years, 6 months ago
Reviewers:
michaeln, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, alecflett
Visibility:
Public.

Description

IndexedDB: Remove IPC plumbing for obsolete property accessors. Now that webkit.org/b/88467 has landed the IDB front end can directly respond to property requests (name, version, flags, etc) from script, so the IPC plumbing to route these requests to the back end can be removed. R=michaeln@chromium.org,dgrogan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -269 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.h View 3 chunks +0 lines, -15 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 6 chunks +0 lines, -97 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 3 chunks +0 lines, -55 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jsbell
michaeln@ - in http://codereview.chromium.org/10533057/#msg2 you asked if the other sync accessors could go some day. ...
8 years, 6 months ago (2012-06-23 00:13:02 UTC) #1
jsbell
Note that we can also start to remove the plumbing for: WebIDBTransaction::mode() - can be ...
8 years, 6 months ago (2012-06-23 00:18:13 UTC) #2
dgrogan
LGTM Not often you see a CL that is strictly deleting lines.
8 years, 6 months ago (2012-06-23 00:19:52 UTC) #3
michaeln
LGTM2, nice to see the deletions! Looks like your starting to bump up against the ...
8 years, 6 months ago (2012-06-23 17:55:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10657011/1
8 years, 6 months ago (2012-06-25 17:23:00 UTC) #5
commit-bot: I haz the power
Try job failure for 10657011-1 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=40242 Step "update" is always ...
8 years, 6 months ago (2012-06-25 17:58:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/10657011/1
8 years, 6 months ago (2012-06-25 22:24:48 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 23:30:56 UTC) #8
Change committed as 144052

Powered by Google App Engine
This is Rietveld 408576698