Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: content/shell/layout_test_controller_host.h

Issue 10656044: Add basic support to dump pixel results (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/layout_test_controller_host.h
diff --git a/content/shell/layout_test_controller_host.h b/content/shell/layout_test_controller_host.h
index 733dfc9c8dc9b5c88670d9d9082a6fb170113ad5..f078608d9051474651fd3f037a017c0021d9e5bb 100644
--- a/content/shell/layout_test_controller_host.h
+++ b/content/shell/layout_test_controller_host.h
@@ -11,6 +11,8 @@
#include "content/public/browser/render_view_host_observer.h"
+class SkBitmap;
+
namespace content {
class LayoutTestControllerHost : public RenderViewHostObserver {
@@ -18,6 +20,9 @@ class LayoutTestControllerHost : public RenderViewHostObserver {
static LayoutTestControllerHost* FromRenderViewHost(
RenderViewHost* render_view_host);
+ // Initialize the LayoutTestControllerHost for a given test.
+ static void Init(const std::string& expected_pixel_hash);
+
explicit LayoutTestControllerHost(RenderViewHost* render_view_host);
virtual ~LayoutTestControllerHost();
@@ -34,6 +39,7 @@ class LayoutTestControllerHost : public RenderViewHostObserver {
// Message handlers.
void OnDidFinishLoad();
void OnTextDump(const std::string& dump);
+ void OnImageDump(const SkBitmap& image);
// layoutTestController handlers.
void OnNotifyDone();
@@ -44,6 +50,7 @@ class LayoutTestControllerHost : public RenderViewHostObserver {
void OnWaitUntilDone();
static std::map<RenderViewHost*, LayoutTestControllerHost*> controllers_;
+ static std::string expected_pixel_hash_;
bool dump_as_text_;
bool dump_child_frames_;

Powered by Google App Engine
This is Rietveld 408576698