Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: webkit/fileapi/isolated_context.h

Issue 10656039: Comment fix for r144115 (Manage IsolatedContext with reference counts) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/fileapi/isolated_context.h
diff --git a/webkit/fileapi/isolated_context.h b/webkit/fileapi/isolated_context.h
index fa6d0a9ef0011d81c969f509eb0e3b6778611f34..de5a71f71c5de390edc408ff77095e3cdc994983 100644
--- a/webkit/fileapi/isolated_context.h
+++ b/webkit/fileapi/isolated_context.h
@@ -36,6 +36,8 @@ class FILEAPI_EXPORT IsolatedContext {
// key and the ID for the newly created filesystem to the renderer for
// the sake of security.
//
+ // Note that all the given paths in |fileset| must be absolute paths.
+ //
// The renderer will be sending filesystem requests with a virtual path like
// '/<filesystem_id>/<relative_path_from_the_basename_of_dropped_path>'
// for which we could crack in the browser by calling CrackIsolatedPath to
@@ -48,9 +50,6 @@ class FILEAPI_EXPORT IsolatedContext {
// internal mapping. Similarly if a dropped entry is a directory and its
// path is like '/a/b/dir' a virtual path like '/<fsid>/dir/foo' can be
// cracked into '/a/b/dir/foo'.
- //
- // This may return an empty string (thus invalid as an ID) if the given
- // file set contains non absolute paths.
std::string RegisterIsolatedFileSystem(const std::set<FilePath>& fileset);
// Revokes filesystem specified by the given filesystem_id.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698