Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10656027: Increase default buffer size when back end can't recommend one. (Closed)

Created:
8 years, 6 months ago by nfullagar
Modified:
8 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Increase default buffer size when back end can't recommend one. This should help avoid stuttering on older XP machines, or vista machines where hardware sample rate != application sample rate. The downside is audio latency will be higher. Old value was for 30ms buffers. New value is for 50ms buffers. TEST=verify w/ nhu...@adobe.com once in canary BUG=http://code.google.com/p/chromium/issues/detail?id=133393 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144258

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M ppapi/shared_impl/ppb_audio_config_shared.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nfullagar
8 years, 6 months ago (2012-06-25 22:04:32 UTC) #1
brettw
lgtm
8 years, 6 months ago (2012-06-26 03:58:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10656027/6001
8 years, 6 months ago (2012-06-26 19:23:59 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-26 20:29:18 UTC) #4
Change committed as 144258

Powered by Google App Engine
This is Rietveld 408576698