Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 10656018: Separate stub types from property types. (Closed)

Created:
8 years, 6 months ago by Toon Verwaest
Modified:
8 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Separate stub types from property types. Committed: https://code.google.com/p/v8/source/detail?r=11920

Patch Set 1 #

Total comments: 3

Patch Set 2 : Moving StubType to Code #

Patch Set 3 : Shrink the bitfield containing the stubtype. #

Patch Set 4 : Also moving all other bits to the left #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -209 lines) Patch
M src/arm/ic-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/stub-cache-arm.cc View 1 30 chunks +34 lines, -30 lines 0 comments Download
M src/disassembler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 30 chunks +34 lines, -30 lines 0 comments Download
M src/ic.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/ic-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 30 chunks +34 lines, -30 lines 0 comments Download
M src/objects.h View 1 2 3 5 chunks +22 lines, -11 lines 0 comments Download
M src/objects.cc View 1 7 chunks +8 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/property.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/property-details.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/stub-cache.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M src/stub-cache.cc View 1 40 chunks +50 lines, -41 lines 0 comments Download
M src/type-info.cc View 1 5 chunks +7 lines, -5 lines 0 comments Download
M src/x64/ic-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/stub-cache-x64.cc View 1 29 chunks +33 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL.
8 years, 6 months ago (2012-06-25 09:09:00 UTC) #1
Jakob Kummerow
8 years, 6 months ago (2012-06-25 10:40:31 UTC) #2
LGTM with comments.

https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode182
src/objects.h:182: enum StubType {
How do you feel about moving this into the Code class? It would require
inserting a bunch of "Code::" everywhere, but I think it'd be cleaner. In turn,
you could probably remove the _STUB part of the values' names.

https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode183
src/objects.h:183: NORMAL_STUB              = 0,
no need to explicitly define the values.

https://chromiumcodereview.appspot.com/10656018/diff/1/src/objects.h#newcode4567
src/objects.h:4567: class TypeField: public BitField<StubType, 3, 4> {};
You don't need 4 bits for an enum with 7 possible values. Please either reduce
the BitField size to 3, or add a comment pointing out that there's a slack bit
in there that can be reclaimed if it's needed for some other purpose.

Powered by Google App Engine
This is Rietveld 408576698