Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: ui/base/ime/input_method_ibus.h

Issue 10656017: Clean UP: Remove IBusClientImpl from ui/base/ime/* (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Cl for review Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/input_method_ibus.h
diff --git a/ui/base/ime/input_method_ibus.h b/ui/base/ime/input_method_ibus.h
index d5c1a90b73296673dd8b3bd6df13b463472af1b5..17c9ec5e4f63c3cc77d1d406c47783dd31c94997 100644
--- a/ui/base/ime/input_method_ibus.h
+++ b/ui/base/ime/input_method_ibus.h
@@ -18,6 +18,9 @@
#include "ui/base/ime/ibus_client.h"
#include "ui/base/ime/input_method_base.h"
+namespace dbus {
+class ObjectPath;
+};
Yusuke Sato 2012/06/25 13:41:33 remove ;
Seigo Nonaka 2012/06/28 03:43:03 Done.
namespace chromeos {
namespace ibus {
class IBusText;
@@ -65,8 +68,8 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase {
CompositionText* out_composition) const;
private:
- class PendingKeyEventImpl;
- class PendingCreateICRequestImpl;
+ class PendingKeyEvent;
+ class PendingCreateICRequest;
// Overridden from InputMethodBase:
virtual void OnWillChangeFocusedClient(TextInputClient* focused_before,
@@ -128,7 +131,7 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase {
// Called when a pending key event has finished. The event will be removed
// from |pending_key_events_|.
- void FinishPendingKeyEvent(PendingKeyEventImpl* pending_key);
+ void FinishPendingKeyEvent(PendingKeyEvent* pending_key);
// Abandons all pending key events. It usually happends when we lose keyboard
// focus, the text input type is changed or we are destroyed.
@@ -138,6 +141,12 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase {
// object proxy.
void ResetInputContext();
+ // Returns true if the connection to ibus-daemon is established.
+ bool IsConnected();
+
+ // Returns true if the input context is ready to use.
+ bool IsContextReady();
+
// Event handlers for IBusInputContext:
void OnCommitText(const chromeos::ibus::IBusText& text);
void OnForwardKeyEvent(uint32 keyval, uint32 keycode, uint32 status);
@@ -147,9 +156,10 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase {
bool visible);
void OnHidePreeditText();
- void CreateInputContextDone(PendingCreateICRequestImpl* ic_request,
+ void CreateInputContextDone(PendingCreateICRequest* ic_request,
const dbus::ObjectPath& object_path);
- static void ProcessKeyEventDone(PendingKeyEventImpl* pending_key_event,
+ void CreateInputContextFail(PendingCreateICRequest* ic_request);
+ static void ProcessKeyEventDone(PendingKeyEvent* pending_key_event,
bool is_handled);
scoped_ptr<internal::IBusClient> ibus_client_;
@@ -157,11 +167,11 @@ class UI_EXPORT InputMethodIBus : public InputMethodBase {
// All pending key events. Note: we do not own these object, we just save
// pointers to these object so that we can abandon them when necessary.
// They will be deleted in ProcessKeyEventDone().
- std::set<PendingKeyEventImpl*> pending_key_events_;
+ std::set<PendingKeyEvent*> pending_key_events_;
// The pending request for creating the input context. We need to keep this
// pointer so that we can receive or abandon the result.
- PendingCreateICRequestImpl* pending_create_ic_request_;
+ PendingCreateICRequest* pending_create_ic_request_;
// Pending composition text generated by the current pending key event.
// It'll be sent to the focused text input client as soon as we receive the

Powered by Google App Engine
This is Rietveld 408576698