Clean UP: Remove IBusClientImpl from ui/base/ime/*

Remove IBusClientImpl from ui/base/ime/*

BUG=126947
TEST=ran ui_unittests and checked on lumpy

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144677

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144696

[Yusuke Sato, 2012-06-25 13:41:33]

lgtm

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/ibus_client.cc
File ui/base/ime/ibus_client.cc (right):

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/ibus_client.cc#...
ui/base/ime/ibus_client.cc:27: chromeos::IBusInputContextClient* client =
I prefer input_context or input_context_client.

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/ibus_client.h
File ui/base/ime/ibus_client.h (right):

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/ibus_client.h#n...
ui/base/ime/ibus_client.h:19: // An interface implemented by the object that
sends and receives an event to
not an interface anymore.

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.cc (right):

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.cc:228: : ibus_client_(new
internal::IBusClient()),
omit () for style consistency

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/input_method_ib...
File ui/base/ime/input_method_ibus.h (right):

http://codereview.chromium.org/10656017/diff/5001/ui/base/ime/input_method_ib...
ui/base/ime/input_method_ibus.h:23: };
remove ;

[Seigo Nonaka, 2012-06-28 03:43:03]

Thanks, I will submit after check try bot just in case.

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/ibus_cl...
File ui/base/ime/ibus_client.cc (right):

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/ibus_cl...
ui/base/ime/ibus_client.cc:27: chromeos::IBusInputContextClient* client =
On 2012/06/25 13:41:33, Yusuke Sato wrote:
> I prefer input_context or input_context_client.

Done.

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/ibus_cl...
File ui/base/ime/ibus_client.h (right):

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/ibus_cl...
ui/base/ime/ibus_client.h:19: // An interface implemented by the object that
sends and receives an event to
On 2012/06/25 13:41:33, Yusuke Sato wrote:
> not an interface anymore.

Done.

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/input_m...
File ui/base/ime/input_method_ibus.cc (right):

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/input_m...
ui/base/ime/input_method_ibus.cc:228: : ibus_client_(new
internal::IBusClient()),
On 2012/06/25 13:41:33, Yusuke Sato wrote:
> omit () for style consistency

Done.

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/input_m...
File ui/base/ime/input_method_ibus.h (right):

https://chromiumcodereview.appspot.com/10656017/diff/5001/ui/base/ime/input_m...
ui/base/ime/input_method_ibus.h:23: };
On 2012/06/25 13:41:33, Yusuke Sato wrote:
> remove ;

Done.

[commit-bot: I haz the power, 2012-06-28 04:18:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10656017/15002

[commit-bot: I haz the power, 2012-06-28 06:27:21]

Change committed as 144677

[Seigo Nonaka, 2012-06-28 08:16:08]

Sorry, I broke the tree because the chromeos specific source code is wrongly
compiled on win_aura.
Let me submit CL as second try because the fix is quite trivial.

[commit-bot: I haz the power, 2012-06-28 08:16:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10656017/31003

[commit-bot: I haz the power, 2012-06-28 10:35:20]

Change committed as 144696