Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 10654002: Pass arguments to pylint child process via a pipe. (Closed)

Created:
8 years, 6 months ago by chrisha
Modified:
8 years, 6 months ago
Reviewers:
M-A Ruel, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Pass arguments to pylint child process via a pipe. This gets around command-line length limitations. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143620

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
M presubmit_canned_checks.py View 1 chunk +16 lines, -3 lines 0 comments Download
A pylint View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A pylint.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +13 lines, -3 lines 0 comments Download
M third_party/pylint.py View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
chrisha
PTAL.
8 years, 6 months ago (2012-06-22 14:51:48 UTC) #1
M-A Ruel
lgtm https://chromiumcodereview.appspot.com/10654002/diff/2001/third_party/pylint.py File third_party/pylint.py (right): https://chromiumcodereview.appspot.com/10654002/diff/2001/third_party/pylint.py#newcode31 third_party/pylint.py:31: if arg: Do you think empty args are ...
8 years, 6 months ago (2012-06-22 15:26:41 UTC) #2
chrisha
Thanks, submitting to CQ. https://chromiumcodereview.appspot.com/10654002/diff/2001/third_party/pylint.py File third_party/pylint.py (right): https://chromiumcodereview.appspot.com/10654002/diff/2001/third_party/pylint.py#newcode31 third_party/pylint.py:31: if arg: On 2012/06/22 15:26:41, ...
8 years, 6 months ago (2012-06-22 17:05:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisha@chromium.org/10654002/4003
8 years, 6 months ago (2012-06-22 17:05:26 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 17:08:13 UTC) #5
Change committed as 143620

Powered by Google App Engine
This is Rietveld 408576698