chromeos: Make Chrome app a real app.

chromeos: Make Chrome app a real app.

- Add a chrome_app component extension similar to web store;
- Remove ChromeAppItem and use the real app;
- Minor clean up;
  - use_aura -> use_ash in browser_resources.grd;
  - Fix style nits;

BUG=133015
TEST=Verify that "chrome" app is searchable.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143966

[xiyuan, 2012-06-21 20:15:04]

asargent, please review all extension related code
sky, please do the overall review.

Thanks.

[sky, 2012-06-21 21:46:34]

LGTM

[asargent_no_longer_on_chrome, 2012-06-21 22:45:08]

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/extensions/c...
File chrome/browser/extensions/component_loader.h (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/extensions/c...
chrome/browser/extensions/component_loader.h:120: void AddChromeAppExtension();
nit: this should probably just be named AddChromeApp

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
File chrome/browser/resources/chrome_app/manifest.json (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chrome_app/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDNuYLEQ1QPMcc5HfWI/9jiEf6FdJWqEtgRmIeI7qtjPLBM5oje+Ny2E2mTAhou5qdJiO2CHWdU1DQXY2F7Zu2gZaKZgHLfK4WimHxUT5Xd9/aro/R9PCzjguM1BLusiWYc9xlj1IsZpyiN1hcjU7SCnBhv1feQlv2WSB5KRiXwhQIDAQAB",
Looks like you just copied this value from the webstore app - for chrome
extensions/apps, the key is actually per-item, not a certificate used to sign
multiple different items. So you should generate a new random key to use. To do
this, just create a dummy empty extension, use the chrome://extensions page to
pack it into a .crx file, install that, find it's id on the chrome://extensions
page, and then look in your <user profile dir>/Preferences file to find the
entry for that extension and copy the key value out. Also that id should be the
value that you use for the kChromeAppId constant. 

(Sorry this is such a hassle - we don't need to do it very often or otherwise
we'd make it easier).

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chrome_app/manifest.json:8: "web_url":
"http://www.google.com/chrome"
Instead of http://www.google.com/chrome, can we make the url be something like
http://DUMMY-VALUE or http://THIS-WILL-BE-REPLACED?

Also can you please add a comment here that mentions that this will be changed
by special case to become chrome://newtab? (Our json parser supports c-style
comments with a leading // delimiter).

http://codereview.chromium.org/10652003/diff/2002/chrome/common/extensions/ex...
File chrome/common/extensions/extension_constants.h (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/common/extensions/ex...
chrome/common/extensions/extension_constants.h:116: #if defined(USE_ASH)
nit: this probably doesn't need be in an USE_ASH ifdef (In fact, I think you'll
currently get a compile error because you use it outside of an ifdef in
extension.cc).

[xiyuan, 2012-06-21 23:19:44]

Please take another look. Thanks.

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/extensions/c...
File chrome/browser/extensions/component_loader.h (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/extensions/c...
chrome/browser/extensions/component_loader.h:120: void AddChromeAppExtension();
On 2012/06/21 22:45:08, Antony Sargent wrote:
> nit: this should probably just be named AddChromeApp

Done.

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
File chrome/browser/resources/chrome_app/manifest.json (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chrome_app/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDNuYLEQ1QPMcc5HfWI/9jiEf6FdJWqEtgRmIeI7qtjPLBM5oje+Ny2E2mTAhou5qdJiO2CHWdU1DQXY2F7Zu2gZaKZgHLfK4WimHxUT5Xd9/aro/R9PCzjguM1BLusiWYc9xlj1IsZpyiN1hcjU7SCnBhv1feQlv2WSB5KRiXwhQIDAQAB",
On 2012/06/21 22:45:08, Antony Sargent wrote:
> Looks like you just copied this value from the webstore app - for chrome
> extensions/apps, the key is actually per-item, not a certificate used to sign
> multiple different items. So you should generate a new random key to use. To
do
> this, just create a dummy empty extension, use the chrome://extensions page to
> pack it into a .crx file, install that, find it's id on the
chrome://extensions
> page, and then look in your <user profile dir>/Preferences file to find the
> entry for that extension and copy the key value out. Also that id should be
the
> value that you use for the kChromeAppId constant. 
> 
> (Sorry this is such a hassle - we don't need to do it very often or otherwise
> we'd make it easier). 
> 

Actually, this is a different key from webstore. :) I followed your steps to get
this key created. It just happened to be the same on the first 39 chars.

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chrome_app/manifest.json:8: "web_url":
"http://www.google.com/chrome"
On 2012/06/21 22:45:08, Antony Sargent wrote:
> Instead of http://www.google.com/chrome, can we make the url be something like
> http://DUMMY-VALUE or http://THIS-WILL-BE-REPLACED?
> 
> Also can you please add a comment here that mentions that this will be changed
> by special case to become chrome://newtab? (Our json parser supports c-style
> comments with a leading // delimiter). 
> 

Done.

http://codereview.chromium.org/10652003/diff/2002/chrome/common/extensions/ex...
File chrome/common/extensions/extension_constants.h (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/common/extensions/ex...
chrome/common/extensions/extension_constants.h:116: #if defined(USE_ASH)
On 2012/06/21 22:45:08, Antony Sargent wrote:
> nit: this probably doesn't need be in an USE_ASH ifdef (In fact, I think
you'll
> currently get a compile error because you use it outside of an ifdef in
> extension.cc).
> 

You are right. Removed the #if defined.

[asargent_no_longer_on_chrome, 2012-06-22 23:25:38]

LGTM

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
File chrome/browser/resources/chrome_app/manifest.json (right):

http://codereview.chromium.org/10652003/diff/2002/chrome/browser/resources/ch...
chrome/browser/resources/chrome_app/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDNuYLEQ1QPMcc5HfWI/9jiEf6FdJWqEtgRmIeI7qtjPLBM5oje+Ny2E2mTAhou5qdJiO2CHWdU1DQXY2F7Zu2gZaKZgHLfK4WimHxUT5Xd9/aro/R9PCzjguM1BLusiWYc9xlj1IsZpyiN1hcjU7SCnBhv1feQlv2WSB5KRiXwhQIDAQAB",
On 2012/06/21 23:19:44, xiyuan wrote:
> On 2012/06/21 22:45:08, Antony Sargent wrote:
> > Looks like you just copied this value from the webstore app - for chrome
> > extensions/apps, the key is actually per-item, not a certificate used to
sign
> > multiple different items. So you should generate a new random key to use. To
> do
> > this, just create a dummy empty extension, use the chrome://extensions page
to
> > pack it into a .crx file, install that, find it's id on the
> chrome://extensions
> > page, and then look in your <user profile dir>/Preferences file to find the
> > entry for that extension and copy the key value out. Also that id should be
> the
> > value that you use for the kChromeAppId constant. 
> > 
> > (Sorry this is such a hassle - we don't need to do it very often or
otherwise
> > we'd make it easier). 
> > 
> 
> Actually, this is a different key from webstore. :) I followed your steps to
get
> this key created. It just happened to be the same on the first 39 chars.

The last 7 characters too! That defeated my typical "eyeball the difference
between two long hashes by looking at the first few and last few chars"
algorithm. =)

[xiyuan, 2012-06-25 16:25:22]

jhawkins, could you do owner review for chrome/browser/resources?

Thanks.

[James Hawkins, 2012-06-25 16:29:20]

Rubber-stamp LGTM.

[commit-bot: I haz the power, 2012-06-25 17:36:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10652003/14001

[commit-bot: I haz the power, 2012-06-25 18:44:22]

Change committed as 143966