src/runtime.cc - Issue 10649008: Fix sharing of literal boilerplates for optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 10649008: Fix sharing of literal boilerplates for optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index df8e8d7c6448889c0ae7689a8e7d0ac199895aae..82206dd12675514aeef99eaed9a52b55b56886e2 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -635,6 +635,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_CreateArrayLiteral) {

// Check if boilerplate exists. If not, create it first.

Handle<Object> boilerplate(literals->get(literals_index), isolate);

if (*boilerplate == isolate->heap()->undefined_value()) {

+ ASSERT(*elements != isolate->heap()->empty_fixed_array());

boilerplate =

Runtime::CreateArrayLiteralBoilerplate(isolate, literals, elements);

if (boilerplate.is_null()) return Failure::Exception();

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-2193.js » ('j') | no next file with comments »