chrome/browser/extensions/active_tab_permission_manager.cc - Issue 10649003: Move each permission classes to its own files in extensions/permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_manager.cc

Issue 10649003: Move each permission classes to its own files in extensions/permissions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase on HEAD Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/debugger/devtools_window.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_storage_delegate.cc » ('j') | chrome/browser/extensions/extension_info_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/active_tab_permission_manager.cc

diff --git a/chrome/browser/extensions/active_tab_permission_manager.cc b/chrome/browser/extensions/active_tab_permission_manager.cc

index 1c52caf84f98eb32fd2b15367e0e9f8cbe864ad2..fb8a08f5a5139438748677c9ee84ce3df6ffe4ea 100644

--- a/chrome/browser/extensions/active_tab_permission_manager.cc

+++ b/chrome/browser/extensions/active_tab_permission_manager.cc

@@ -12,7 +12,7 @@

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_messages.h"

-#include "chrome/common/extensions/extension_permission_set.h"

+#include "chrome/common/extensions/permissions/permission_set.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

@@ -22,6 +22,7 @@

using content::RenderProcessHost;

using content::WebContentsObserver;

+using extensions::APIPermission;

namespace extensions {

@@ -38,7 +39,7 @@ ActiveTabPermissionManager::ActiveTabPermissionManager(

ActiveTabPermissionManager::~ActiveTabPermissionManager() {}

void ActiveTabPermissionManager::GrantIfRequested(const Extension* extension) {

- if (!extension->HasAPIPermission(ExtensionAPIPermission::kActiveTab))

+ if (!extension->HasAPIPermission(APIPermission::kActiveTab))

return;

if (active_urls_.is_empty())