Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: runtime/vm/debugger.cc

Issue 10645003: Do not collect stack trace unnecessarily (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 8992)
+++ runtime/vm/debugger.cc (working copy)
@@ -638,7 +638,9 @@
// This is probably not conservative enough (we could set the first
// breakpoint after optimized code has already been produced).
// Long-term, we need to be able to de-optimize code.
- return (src_breakpoints_ != NULL) || (code_breakpoints_ != NULL);
+ return (src_breakpoints_ != NULL) ||
+ (code_breakpoints_ != NULL) ||
+ (exc_pause_info_ != kNoPauseOnExceptions);
}
@@ -754,6 +756,9 @@
void Debugger::SetExceptionPauseInfo(Dart_ExceptionPauseInfo pause_info) {
+ ASSERT((pause_info == kNoPauseOnExceptions) ||
+ (pause_info == kPauseOnUnhandledExceptions) ||
+ (pause_info == kPauseOnAllExceptions));
exc_pause_info_ = pause_info;
}
@@ -783,7 +788,9 @@
void Debugger::SignalExceptionThrown(const Object& exc) {
- if (ignore_breakpoints_ || (event_handler_ == NULL)) {
+ if (ignore_breakpoints_ ||
+ (event_handler_ == NULL) ||
+ (exc_pause_info_ == kNoPauseOnExceptions)) {
return;
}
DebuggerStackTrace* stack_trace = CollectStackTrace();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698