content/renderer/render_frame_impl.h - Issue 1064413003: PlzNavigate: make RenderViewtest helper functions work

Unified Diff: content/renderer/render_frame_impl.h

Issue 1064413003: PlzNavigate: make RenderViewtest helper functions work (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/test/render_view_test.cc ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 47c9620b44205b392a3490b2ffa6c6c4fdeb6d09..14a6c6a67e807e63142d28ed2412f2817cf96b78 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -564,6 +564,7 @@ class CONTENT_EXPORT RenderFrameImpl

private:

friend class RenderFrameImplTest;

friend class RenderFrameObserver;

+ friend class RenderViewImplTest;

clamy 2015/04/08 14:19:30 This is to not make the OnCommitNavigation handler

carlosk 2015/04/08 15:16:42 Instead of friending the test you could call OnMes

clamy 2015/04/09 15:55:06 Considering Nasko's comment at line 539, I will ha

Charlie Reis 2015/04/09 16:04:51 Actually, Nasko was referring to the FRIEND_TEST_A

friend class RendererAccessibilityTest;

FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuDisplayNoneTest, SelectItem);

FRIEND_TEST_ALL_PREFIXES(ExternalPopupMenuRemoveTest, RemoveOnChange);

« content/public/test/render_view_test.cc ('K') | « content/public/test/render_view_test.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_frame_impl.cc » ('J')