PlzNavigate: make RenderViewtest helper functions work

content/renderer/render_frame_impl.cc

Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 8915dea7ec91fbd213aceb3082888316ef559384..bc0ff19ab9da5e6ab09ae4f65fa445fd3d3d97fd 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1064,6 +1064,8 @@ void RenderFrameImpl::OnNavigate(
     const CommonNavigationParams& common_params,
     const StartNavigationParams& start_params,
     const RequestNavigationParams& request_params) {
+  CHECK(!base::CommandLine::ForCurrentProcess()->HasSwitch(

[clamy, 2015/04/08 14:19:30]

I added the CHECK to catch tests that manually call OnNavigate, and where we
don't properly exercise the PlzNavigate path.

[carlosk, 2015/04/08 15:16:42]

Good idea! Will make it way easier to find those many cases.

[Charlie Reis, 2015/04/09 00:47:40]

Sounds good.  Can you make this a DCHECK instead?  That will still run on both
the debug and release bots, but it won't get compiled into release builds for
users.

[clamy, 2015/04/09 15:55:06]

Done.

+      switches::kEnableBrowserSideNavigation));
   TRACE_EVENT2("navigation", "RenderFrameImpl::OnNavigate", "id", routing_id_,
                "url", common_params.url.possibly_invalid_spec());