Issue 10644008: Make SendGeolocationPermissionResponse execute on UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10644008: Make SendGeolocationPermissionResponse execute on UI thread. (Closed)

Created:
8 years, 6 months ago by John Knottenbelt

Modified:
8 years, 6 months ago

Reviewers:
bulach, joth

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, joth

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make SendGeolocationPermissionResponse execute on UI thread. SendGeolocationPermissionResponse can be called on the IO thread from GeolocationDispatcherHostImpl::OnRequestPermission if there is no geolocation_permission_context_ (as is the case with content shell). But, SendGeolocationPermissionResponse calls RenderViewHostImpl::FromID which must be called on the UI thread, so we need to ensure that SendGeolocationPermissionResponse is called on the UI thread too. BUG=134116 TEST=Geolocation Browser Tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143882

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	content/browser/geolocation/geolocation_dispatcher_host.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jknotten@chromium.org/10644008/1

8 years, 6 months ago (2012-06-25 06:48:42 UTC) #5

Change committed as 143882

Expand Messages | Collapse Messages