Add core plumbing for Instant Extended work

chrome/browser/google/google_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_url_tracker.h"
 #include "chrome/browser/google/google_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using google_util::IsGoogleDomainUrl;
 using google_util::IsGoogleHomePageUrl;
 using google_util::IsGoogleSearchUrl;
+using google_util::IsEmbeddedGoogleSearchUrl;
 
 TEST(GoogleUtilTest, GoodHomePagesNonSecure) {
   // Valid home page hosts.
   EXPECT_TRUE(IsGoogleHomePageUrl(GoogleURLTracker::kDefaultGoogleHomepage));
   EXPECT_TRUE(IsGoogleHomePageUrl("http://google.com"));
   EXPECT_TRUE(IsGoogleHomePageUrl("http://www.google.com"));
   EXPECT_TRUE(IsGoogleHomePageUrl("http://www.google.ca"));
   EXPECT_TRUE(IsGoogleHomePageUrl("http://www.google.co.uk"));
   EXPECT_TRUE(IsGoogleHomePageUrl("http://www.google.com:80/"));
 
@@ skipping 214 matching lines @@
       "http://www.google.com/webhp/nogood#q=something"));
   EXPECT_FALSE(IsGoogleSearchUrl(""));
 
   // Case sensitive paths.
   EXPECT_FALSE(IsGoogleSearchUrl(
       "http://www.google.com/SEARCH?q=something"));
   EXPECT_FALSE(IsGoogleSearchUrl(
       "http://www.google.com/WEBHP#q=something"));
 }
 
+TEST(GoogleUtilTest, IsEmbeddedGoogleSearchUrl) {
+  EXPECT_TRUE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&espv=1"));
+  EXPECT_TRUE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&espv=3"));
+  EXPECT_TRUE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&espv=42"));
+
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&espv="));

[Ilya Sherman, 2012/06/21 17:46:58]

nit: Please also add a test for espv=0 on google.com

[dhollowa, 2012/06/21 22:16:43]

Done.

+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.foo.com/search?q=something&espv=0"));
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.foo.com/search?q=something&espv=1"));
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/bing?q=something&espv=1"));
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&vespv=1"));
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search?q=something&espvx=1"));
+  EXPECT_FALSE(IsEmbeddedGoogleSearchUrl(
+        "http://www.google.com/search#q=something&espv=1"));
+}
+
 TEST(GoogleUtilTest, GoogleDomains) {
   // Test some good Google domains (valid TLDs).
   EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.com",
                                 google_util::ALLOW_SUBDOMAIN));
   EXPECT_TRUE(IsGoogleDomainUrl("http://google.com",
                                 google_util::ALLOW_SUBDOMAIN));
   EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.ca",
                                 google_util::ALLOW_SUBDOMAIN));
   EXPECT_TRUE(IsGoogleDomainUrl("http://www.google.biz.tj",
                                 google_util::ALLOW_SUBDOMAIN));
@@ skipping 27 matching lines @@
                                  google_util::DISALLOW_SUBDOMAIN));
   EXPECT_TRUE(IsGoogleDomainUrl("https://www.google.com:443",
                                 google_util::DISALLOW_SUBDOMAIN));
   EXPECT_FALSE(IsGoogleDomainUrl("https://www.google.com:123",
                                  google_util::DISALLOW_SUBDOMAIN));
   EXPECT_FALSE(IsGoogleDomainUrl("file://www.google.com",
                                  google_util::DISALLOW_SUBDOMAIN));
   EXPECT_FALSE(IsGoogleDomainUrl("doesnotexist://www.google.com",
                                  google_util::DISALLOW_SUBDOMAIN));
 }