Add core plumbing for Instant Extended work

chrome/browser/google/google_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/google/google_util.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 185 matching lines @@
     return false;
 
   // Check for query parameter in URL parameter and hash fragment, depending on
   // the path type.
   std::string query(original_url.query());
   std::string ref(original_url.ref());
   return HasQueryParameter(ref) ||
       (!is_home_page_base && HasQueryParameter(query));
 }
 
+bool IsEmbeddedGoogleSearchUrl(const std::string& url) {
+  if (!IsGoogleSearchUrl(url))
+    return false;
+
+  const std::string embedded_search_key = "espv=";
+
+  GURL original_url(url);
+  std::vector<std::string> parameters;
+  base::SplitString(original_url.query(), '&', &parameters);
+  for (std::vector<std::string>::const_iterator it = parameters.begin();
+       it != parameters.end(); ++it) {
+    // If the parameter key is |embedded_search_key| and the value is not 0 this
+    // is an embedded Google search URL.
+    if (StartsWithASCII(*it, embedded_search_key, true)) {
+      std::string value = it->substr(embedded_search_key.length());
+      return value.length() > 0 && value != "0";

[Ilya Sherman, 2012/06/21 17:46:58]

Optional nit: "value.length() > 0" -> "!value.empty()"

[dhollowa, 2012/06/21 22:16:43]

Done.  Rephrased with |Component| terminology.

+    }
+  }

[Ilya Sherman, 2012/06/21 17:46:58]

You might want to use GURL's implementation [1] for extracting query components,
rather than rolling your own... though this code is not very complex, so I'm not
sure which is actually simpler.
https://code.google.com/searchframe#OAMlx_jo-ck/src/googleurl/src/url_parse.h...

[dhollowa, 2012/06/21 22:16:43]

Much better.  Thanks for the tip!

On 2012/06/21 17:46:58, Ilya Sherman wrote:

+  return false;
+}
+
 bool IsOrganic(const std::string& brand) {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kOrganicInstall))
     return true;
 
 #if defined(OS_MACOSX)
   if (brand.empty()) {
     // An empty brand string on Mac is used for channels other than stable,
     // which are always organic.
     return true;
@@ skipping 42 matching lines @@
   const char* const kBrands[] = {
     "CHIQ", "CHSG", "HLJY", "NTMO", "OOBA", "OOBB", "OOBC", "OOBD", "OOBE",
     "OOBF", "OOBG", "OOBH", "OOBI", "OOBJ", "IDCM",
   };
   const char* const* end = &kBrands[arraysize(kBrands)];
   const char* const* found = std::find(&kBrands[0], end, brand);
   return found != end;
 }
 
 }  // namespace google_util