Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 10641016: Add an IPC channel between the NaCl loader process and the renderer. (Closed)

Created:
8 years, 6 months ago by bbudge
Modified:
8 years, 6 months ago
CC:
chromium-reviews, yzshen+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, piman+watch_chromium.org, native-client-reviews_googlegroups.com, ihf+watch_chromium.org
Visibility:
Public.

Description

Add an IPC channel between the NaCl loader process and the renderer. BUG=116317 TEST=ppapi, nacl tests, manual testing for experimental IPC proxy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143656

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -22 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.h View 4 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 6 chunks +20 lines, -3 lines 0 comments Download
M chrome/common/nacl_messages.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/nacl_types.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/nacl/nacl_ipc_adapter.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/nacl/nacl_listener.cc View 2 chunks +26 lines, -1 line 0 comments Download
M chrome/renderer/pepper/ppb_nacl_private_impl.cc View 1 2 2 chunks +179 lines, -5 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_entry_points.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 6 chunks +30 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bbudge
This uses a global map to store ChannelHandles per PP_Instance as before. There's no way ...
8 years, 6 months ago (2012-06-22 15:17:40 UTC) #1
bbudge
Some background: The previous version of this CL broke NaCl integration, specifically two tests of ...
8 years, 6 months ago (2012-06-22 16:56:56 UTC) #2
brettw
lgtm
8 years, 6 months ago (2012-06-22 17:56:30 UTC) #3
dmichael (off chromium)
8 years, 6 months ago (2012-06-22 18:05:06 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698