Issue 10641013: Build fix after r143476

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10641013: Build fix after r143476 (Closed)

Created:
8 years, 6 months ago by Nico

Modified:
8 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Build fix after r143476 BUG=132910 TEST=green bots TBR=oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143482

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/resources/about_conflicts.html	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

oshima

8 years, 6 months ago (2012-06-21 23:17:27 UTC) #2

lgtm

On Thu, Jun 21, 2012 at 3:59 PM, <thakis@chromium.org> wrote:

> Reviewers: oshima,
>
> Description:
> Build fix after r143476
>
> BUG=132910
> TEST=green bots
> TBR=oshima
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=143482<https://src.chromium.org/viewvc/chrome?view=rev&revision=143482>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10641013/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/resources/**about_conflicts.html
>
>
> Index: chrome/browser/resources/**about_conflicts.html
> diff --git a/chrome/browser/resources/**about_conflicts.html
> b/chrome/browser/resources/**about_conflicts.html
> index 7a1f85afbc435e4592d787bc7541f0**2afeeb3b42..**
> d5b7f17000f305025fc9fc48c16fb2**9a535e8998 100644
> --- a/chrome/browser/resources/**about_conflicts.html
> +++ b/chrome/browser/resources/**about_conflicts.html
> @@ -26,7 +26,7 @@ div#header {
>  }
>
>  #header h1 {
> -  background: url('../../app/theme/about_**conflicts.png') 0px 20px
> no-repeat;
> +  background: url('../../app/theme/default_**100_percent/about_conflicts.
> **png') 0px 20px no-repeat;
>   display: inline;
>   margin: 0;
>   padding-bottom: 43px;
> @@ -35,7 +35,7 @@ div#header {
>  }
>
>  html[dir=rtl] #header h1 {
> -  background: url('../../app/theme/about_**conflicts.png') right
> no-repeat;
> +  background: url('../../app/theme/default_**100_percent/about_conflicts.
> **png') right no-repeat;
>   padding-right: 95px;
>   padding-left: 0;
>  }
>
>
>

Expand Messages | Collapse Messages