Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 10641005: Use ui_unittests instead of gfx_unittests. (Closed)

Created:
8 years, 6 months ago by tony
Modified:
8 years, 6 months ago
CC:
chromium-reviews, nsylvain+cc_chromium.org, cmp+cc_chromium.org
Visibility:
Public.

Description

Use ui_unittests instead of gfx_unittests. gfx_unittests is just a copy of ui_unittests and will be removed from gyp. BUG=133864 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143648

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -88 lines) Patch
M masters/master.chromium.chromiumos/master_chromiumos_cfg.py View 2 chunks +1 line, -1 line 0 comments Download
M masters/master.chromium.chromiumos/master_gatekeeper_cfg.py View 2 chunks +1 line, -1 line 0 comments Download
M masters/master.chromium.fyi/master.cfg View 7 chunks +5 lines, -5 lines 0 comments Download
M masters/master.chromium.linux/master_linux_cfg.py View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M masters/master.chromium.lkgr/lkgr_finder.py View 1 3 chunks +16 lines, -16 lines 0 comments Download
M masters/master.chromium.memory.fyi/master.cfg View 1 4 chunks +20 lines, -20 lines 0 comments Download
M masters/master.chromium.memory/master_linux_cfg.py View 2 chunks +1 line, -1 line 0 comments Download
M masters/master.chromium/master_linux_cfg.py View 1 2 chunks +12 lines, -12 lines 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 24 chunks +20 lines, -20 lines 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tony
I just used grep to find instances of gfx and replaced them with ui. I ...
8 years, 6 months ago (2012-06-21 18:44:57 UTC) #1
M-A Ruel
Adding Alexander since I'm unsure about heapcheck in tryserver.chromium https://chromiumcodereview.appspot.com/10641005/diff/1/masters/master.chromium.lkgr/lkgr_finder.py File masters/master.chromium.lkgr/lkgr_finder.py (right): https://chromiumcodereview.appspot.com/10641005/diff/1/masters/master.chromium.lkgr/lkgr_finder.py#newcode99 masters/master.chromium.lkgr/lkgr_finder.py:99: ...
8 years, 6 months ago (2012-06-21 18:57:23 UTC) #2
tony
I sorted all the blocks and removed the "# from test target unit" comments. I ...
8 years, 6 months ago (2012-06-21 19:16:51 UTC) #3
Alexander Potapenko
On 2012/06/21 19:16:51, tony wrote: > I sorted all the blocks and removed the "# ...
8 years, 6 months ago (2012-06-21 19:25:06 UTC) #4
tony
On 2012/06/21 19:25:06, Alexander Potapenko wrote: > On 2012/06/21 19:16:51, tony wrote: > > I ...
8 years, 6 months ago (2012-06-21 20:09:12 UTC) #5
cmp
lgtm
8 years, 6 months ago (2012-06-21 22:17:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/10641005/8001
8 years, 6 months ago (2012-06-22 18:35:43 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-22 18:37:09 UTC) #8
Change committed as 143648

Powered by Google App Engine
This is Rietveld 408576698