Issue 10641004: Speedup the validator-x86_64.c compilation by 15%

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10641004: Speedup the validator-x86_64.c compilation by 15% (Closed)

Created:
8 years, 6 months ago by khim

Modified:
8 years, 6 months ago

Reviewers:
Nick Bray, Mark Seaborn

CC:
native-client-reviews_googlegroups.com, bradn

Base URL:
svn://svn.chromium.org/native_client/trunk/

Visibility:
Public.

More Reviews

Description

Speedup the validator-x86_64.c compilation by 15% This means that our Opteron-based bots will compile the file in 8:30 instead of 10:00 which should fix timeout flakiness. BUG=http://code.google.com/p/chromium/issues/detail?id=133601 TEST=trybots Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9010 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9011

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+647 lines, -4951 lines)			Patch
M	deps/third_party/ragel/01-ragel-6.7.GT2.patch	View	1 chunk	+1 line, -1 line	0 comments	Download
M	deps/third_party/ragel/ragel.linux	View	Binary file		0 comments	Download
M	src/native_client/DEPS	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/native_client/src/trusted/validator_ragel/gen/validator-x86_64.c	View	152 chunks	+645 lines, -4949 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

https://chromiumcodereview.appspot.com/10641004/diff/1/src/native_client/DEPS File src/native_client/DEPS (right): https://chromiumcodereview.appspot.com/10641004/diff/1/src/native_client/DEPS#newcode30 src/native_client/DEPS:30: "tools_rev": "9002", SVN revision 9002 does not exist currently. ...

8 years, 6 months ago (2012-06-21 18:15:58 UTC) #2

khim

Yes, I want to create self-referencing commit. What's the problem WRT such commit? I've done ...

8 years, 6 months ago (2012-06-21 21:12:34 UTC) #3

pasko-google - do not use

8 years, 6 months ago (2012-06-22 09:00:06 UTC) #4

LGTM if you make sure the tools_rev points to the right commit.
I don't care whether it is done in one commit or two, just don't break the tree.

Expand Messages | Collapse Messages