Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: net/url_request/url_request_status.h

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase + fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_fetcher_impl_unittest.cc ('k') | webkit/appcache/appcache_request_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_status.h
diff --git a/net/url_request/url_request_status.h b/net/url_request/url_request_status.h
index 5cf1218287b88cb8cf39824c6e8199339aba126c..521a3d45f5fa94b043e9c4a12ac7a5bce99386f2 100644
--- a/net/url_request/url_request_status.h
+++ b/net/url_request/url_request_status.h
@@ -22,11 +22,6 @@ class URLRequestStatus {
// completed.
IO_PENDING,
- // Request was successful but was handled by an external program, so there
- // is no response data. This usually means the current page should not be
- // navigated, but no error should be displayed. |error_| will be 0.
- HANDLED_EXTERNALLY,
-
// Request was cancelled programatically.
CANCELED,
@@ -44,9 +39,7 @@ class URLRequestStatus {
void set_error(int e) { error_ = e; }
// Returns true if the status is success, which makes some calling code more
- // convenient because this is the most common test. Note that we do NOT treat
- // HANDLED_EXTERNALLY as success. For everything except user notifications,
- // this value should be handled like an error (processing should stop).
+ // convenient because this is the most common test.
bool is_success() const {
return status_ == SUCCESS || status_ == IO_PENDING;
}
« no previous file with comments | « net/url_request/url_fetcher_impl_unittest.cc ('k') | webkit/appcache/appcache_request_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698