Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3364)

Unified Diff: chrome/common/extensions/extension_localization_peer.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase + fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_localization_peer.cc
diff --git a/chrome/common/extensions/extension_localization_peer.cc b/chrome/common/extensions/extension_localization_peer.cc
index 3026ea321a995e86fd19870091a05646d415fda2..980d2a46035cb7cc5cb41cf51d666a4053e2ce47 100644
--- a/chrome/common/extensions/extension_localization_peer.cc
+++ b/chrome/common/extensions/extension_localization_peer.cc
@@ -66,19 +66,19 @@ void ExtensionLocalizationPeer::OnReceivedData(const char* data,
}
void ExtensionLocalizationPeer::OnCompletedRequest(
- const net::URLRequestStatus& status,
+ int error_code,
+ bool was_ignored_by_handler,
const std::string& security_info,
const base::TimeTicks& completion_time) {
// Make sure we delete ourselves at the end of this call.
scoped_ptr<ExtensionLocalizationPeer> this_deleter(this);
// Give sub-classes a chance at altering the data.
- if (status.status() != net::URLRequestStatus::SUCCESS) {
+ if (error_code != net::OK) {
// We failed to load the resource.
original_peer_->OnReceivedResponse(response_info_);
- net::URLRequestStatus status(net::URLRequestStatus::CANCELED,
- net::ERR_ABORTED);
- original_peer_->OnCompletedRequest(status, security_info, completion_time);
+ original_peer_->OnCompletedRequest(net::ERR_ABORTED, false, security_info,
+ completion_time);
return;
}
@@ -89,7 +89,8 @@ void ExtensionLocalizationPeer::OnCompletedRequest(
original_peer_->OnReceivedData(data_.data(),
static_cast<int>(data_.size()),
-1);
- original_peer_->OnCompletedRequest(status, security_info, completion_time);
+ original_peer_->OnCompletedRequest(error_code, was_ignored_by_handler,
+ security_info, completion_time);
}
void ExtensionLocalizationPeer::ReplaceMessages() {

Powered by Google App Engine
This is Rietveld 408576698