Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: rebase + fix nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc
diff --git a/chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc b/chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc
index 3c36d11fdafc10dc22205fcd63740eedd1c32191..3852627bb551f55abeee60b8c5c9c3b8092e7a1b 100644
--- a/chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc
+++ b/chrome/browser/renderer_host/intercept_navigation_resource_throttle.cc
@@ -10,8 +10,6 @@
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/browser/resource_controller.h"
-#include "content/public/browser/web_contents.h"
-#include "content/public/browser/web_contents_delegate.h"
#include "content/public/common/referrer.h"
#include "net/url_request/url_request.h"
@@ -20,8 +18,6 @@ using content::ChildProcessSecurityPolicy;
using content::Referrer;
using content::RenderViewHost;
using content::ResourceRequestInfo;
-using content::WebContents;
-using content::WebContentsDelegate;
namespace {
@@ -116,9 +112,7 @@ void InterceptNavigationResourceThrottle::OnResultObtained(
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (should_ignore_navigation) {
- // TODO(mkosiba): Cancel() results in a CANCELLED status but what we really
- // want is a HANDLED_EXTERNALLY status.
- controller()->Cancel();
+ controller()->CancelAndIgnore();
} else {
controller()->Resume();
}

Powered by Google App Engine
This is Rietveld 408576698