Fix liveedit heap traversal bug with write barrier

Fix liveedit heap traversal bug with write barrier

Committed: https://code.google.com/p/v8/source/detail?r=11927

[Peter Rybin, 2012-06-21 22:03:51]

I hope this fixes the issue from http://codereview.chromium.org/10332101/

Must admit I'm a bit in 
http://knowyourmeme.com/photos/234739-i-have-no-idea-what-im-doing  mode.

[Erik Corry, 2012-06-25 11:43:51]

LGTM

http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc#newcode973
src/liveedit.cc:973: // there are pointers in case some of the objects move in a
compacting GC.
I think this comment should read:

// Perform a full GC in order to ensure that we are not in the middle of an
incremental marking phase when we are replacing the code object.  Since we are
not in an incremental marking phase we can write pointers to code objects (that
are never in new space) without worrying about write barriers.

[Peter Rybin, 2012-06-25 21:43:42]

http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

http://codereview.chromium.org/10639006/diff/1/src/liveedit.cc#newcode973
src/liveedit.cc:973: // there are pointers in case some of the objects move in a
compacting GC.
On 2012/06/25 11:43:51, Erik Corry wrote:
> I think this comment should read:
> 
> // Perform a full GC in order to ensure that we are not in the middle of an
> incremental marking phase when we are replacing the code object.  Since we are
> not in an incremental marking phase we can write pointers to code objects
(that
> are never in new space) without worrying about write barriers.

Thank you!