Issue 10639002: Adjust idle notification handler to do full GC at the end of idle round in order to compact code sp…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10639002: Adjust idle notification handler to do full GC at the end of idle round in order to compact code sp… (Closed)

Created:
8 years, 6 months ago by ulan

Modified:
8 years, 6 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Adjust idle notification handler to do full GC at the end of idle round in order to compact code space. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=11900

Patch Set 2 : Add todo #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	src/heap.cc	View	1	2 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). https://chromiumcodereview.appspot.com/10639002/diff/4001/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10639002/diff/4001/src/heap.cc#newcode5100 src/heap.cc:5100: // the code space. Once ...

8 years, 6 months ago (2012-06-21 16:24:12 UTC) #2

ulan

8 years, 6 months ago (2012-06-22 08:15:57 UTC) #3

Landing.

https://chromiumcodereview.appspot.com/10639002/diff/4001/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/10639002/diff/4001/src/heap.cc#newcode...
src/heap.cc:5100: // the code space. Once we enable code compaction for
incremental marking,
On 2012/06/21 16:24:12, Michael Starzinger wrote:
> Maybe mark the second sentence as a TODO, to emphasis that it's only needed
> until we can do code compaction incrementally.

Done.

Expand Messages | Collapse Messages

Issue 10639002: Adjust idle notification handler to do full GC at the end of idle round in order to compact code sp… (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Add todo #

Messages