RenderText: Only clip if necessary to workaround a Skia bug in the PDF path.

RenderText: Expose a flag to disable clipping to workaround a Skia bug in the PDF path.

(See bug for context.)

BUG=133548
TEST=Verify that the clipping problem is solved with (currently unlanded) RenderTextMac code in print preview.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143726

[msw, 2012-06-22 19:30:13]

Can we instead temporarily introduce a flag like clip_to_display_rect_ that the
PDF path can set?

http://codereview.chromium.org/10638015/diff/1/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

http://codereview.chromium.org/10638015/diff/1/ui/gfx/render_text.cc#newcode617
ui/gfx/render_text.cc:617: const bool need_to_clip = display_rect().width() <
size.width() ||
This doesn't account for display_offset_ or other impetus to clip (does
GetStringSize include underline adornment bounds?). That said, I don't know a
specific case where this would actually regress clipping, so it's probably okay
as a temporary workaround.

[Alexei Svitkine (slow), 2012-06-22 20:42:49]

Done.

[msw, 2012-06-22 20:45:05]

That's much nicer, thanks! LGTM

[commit-bot: I haz the power, 2012-06-22 20:50:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10638015/11002

[commit-bot: I haz the power, 2012-06-22 22:15:44]

Change committed as 143726