Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 10638011: Update WebUI for HiDPI images added in r143476 (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 6 months ago
Reviewers:
flackr, James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Update WebUI for HiDPI images added in r143476 BUG=132910 TEST=Top left icon on about:crashes, about:plugins and folder icon on about:bookmarks (on mac) look sharp. TBR=jhawkins Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143588

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M chrome/browser/resources/bookmark_manager/css/bmm.css View 1 chunk +3 lines, -1 line 1 comment Download
M chrome/browser/resources/chromeos/wrench_menu.css View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/crashes.css View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/plugins.css View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
8 years, 6 months ago (2012-06-22 04:40:07 UTC) #1
flackr
LGTM
8 years, 6 months ago (2012-06-22 07:21:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10638011/1
8 years, 6 months ago (2012-06-22 13:25:43 UTC) #3
commit-bot: I haz the power
Presubmit check for 10638011-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-22 13:25:46 UTC) #4
Nico
jhawkins: OWNERS
8 years, 6 months ago (2012-06-22 13:46:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10638011/1
8 years, 6 months ago (2012-06-22 13:46:19 UTC) #6
commit-bot: I haz the power
Presubmit check for 10638011-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-22 13:46:21 UTC) #7
James Hawkins
8 years, 6 months ago (2012-06-22 17:28:53 UTC) #8
LGTM

https://chromiumcodereview.appspot.com/10638011/diff/1/chrome/browser/resourc...
File chrome/browser/resources/bookmark_manager/css/bmm.css (right):

https://chromiumcodereview.appspot.com/10638011/diff/1/chrome/browser/resourc...
chrome/browser/resources/bookmark_manager/css/bmm.css:185:
url('../../../../app/theme/default_100_percent/bookmark_bar_folder_mac.png') 1x,
Ugh, re: ../../../../

Powered by Google App Engine
This is Rietveld 408576698