Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 10637006: Fixes to allow building in an Android tree (Closed)

Created:
8 years, 6 months ago by Steve Block
Modified:
8 years, 6 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, Torne
Visibility:
Public.

Description

Fixes to allow building in an Android tree - Add empty Android.mk to prevent the Android build system from erroneously picking up other Android.mk files. - Rename content_shell_content_view to libcontent_shell_content_view as Android build system requires that shared library target names start with 'lib'. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143925

Patch Set 1 #

Patch Set 2 : Added missing comment char #

Total comments: 2

Patch Set 3 : Removed .gitignore exception #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A Android.mk View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
Steve Block
8 years, 6 months ago (2012-06-22 15:41:25 UTC) #1
Steve Block
http://codereview.chromium.org/10637006/diff/2003/.gitignore File .gitignore (right): http://codereview.chromium.org/10637006/diff/2003/.gitignore#newcode235 .gitignore:235: !Android.mk Currently looking into how to do this for ...
8 years, 6 months ago (2012-06-22 15:52:29 UTC) #2
Steve Block
http://codereview.chromium.org/10637006/diff/2003/.gitignore File .gitignore (right): http://codereview.chromium.org/10637006/diff/2003/.gitignore#newcode235 .gitignore:235: !Android.mk It seems that SVN has no equivalent to ...
8 years, 6 months ago (2012-06-22 16:16:51 UTC) #3
Steve Block
8 years, 6 months ago (2012-06-22 17:35:42 UTC) #4
Yaron
http://codereview.chromium.org/10637006/diff/8001/content/content_shell.gypi File content/content_shell.gypi (right): http://codereview.chromium.org/10637006/diff/8001/content/content_shell.gypi#newcode486 content/content_shell.gypi:486: 'target_name': 'libcontent_shell_content_view', How do you plan to reconcile this ...
8 years, 6 months ago (2012-06-22 18:02:33 UTC) #5
Yaron
lgtm
8 years, 6 months ago (2012-06-25 16:18:59 UTC) #6
Avi (use Gerrit)
8 years, 6 months ago (2012-06-25 16:37:40 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698