Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/debug.cc

Issue 10637003: Correctly support several consecutive stack modifications. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: follow codereview Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/debug.h ('k') | src/liveedit.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2299 matching lines...) Expand 10 before | Expand all | Expand 10 after
2310 } 2310 }
2311 it.next(); 2311 it.next();
2312 } 2312 }
2313 return false; 2313 return false;
2314 } 2314 }
2315 2315
2316 2316
2317 void Debug::FramesHaveBeenDropped(StackFrame::Id new_break_frame_id, 2317 void Debug::FramesHaveBeenDropped(StackFrame::Id new_break_frame_id,
2318 FrameDropMode mode, 2318 FrameDropMode mode,
2319 Object** restarter_frame_function_pointer) { 2319 Object** restarter_frame_function_pointer) {
2320 thread_local_.frame_drop_mode_ = mode; 2320 if (mode != CURRENTLY_SET_MODE) {
2321 thread_local_.frame_drop_mode_ = mode;
2322 }
2321 thread_local_.break_frame_id_ = new_break_frame_id; 2323 thread_local_.break_frame_id_ = new_break_frame_id;
2322 thread_local_.restarter_frame_function_pointer_ = 2324 thread_local_.restarter_frame_function_pointer_ =
2323 restarter_frame_function_pointer; 2325 restarter_frame_function_pointer;
2324 } 2326 }
2325 2327
2326 2328
2327 const int Debug::FramePaddingLayout::kInitialSize = 1; 2329 const int Debug::FramePaddingLayout::kInitialSize = 1;
2328 2330
2329 2331
2330 // Any even value bigger than kInitialSize as needed for stack scanning. 2332 // Any even value bigger than kInitialSize as needed for stack scanning.
(...skipping 1355 matching lines...) Expand 10 before | Expand all | Expand 10 after
3686 { 3688 {
3687 Locker locker; 3689 Locker locker;
3688 Isolate::Current()->debugger()->CallMessageDispatchHandler(); 3690 Isolate::Current()->debugger()->CallMessageDispatchHandler();
3689 } 3691 }
3690 } 3692 }
3691 } 3693 }
3692 3694
3693 #endif // ENABLE_DEBUGGER_SUPPORT 3695 #endif // ENABLE_DEBUGGER_SUPPORT
3694 3696
3695 } } // namespace v8::internal 3697 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/debug.h ('k') | src/liveedit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698