Issue 10636063: Minor tweeks in virtual driver build.

Issue 10636063: Minor tweeks in virtual driver build. (Closed)

Created:
8 years, 6 months ago by Vitaly Buka (NO REVIEWS)

Modified:
8 years, 5 months ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor tweeks in virtual driver build. Fixed missing def file. Combined DEPS file. Copying of ppd file to allow install from build directory. Renamed GCP-driver.ppd -> gcp-driver.ppd Added gcp-driver.ppd into official build files to minimize number of files in signing project. BUG=131058 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144296

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -71 lines)			Patch
M	chrome/tools/build/win/FILES.cfg	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	cloud_print/DEPS	View		1 chunk	+5 lines, -0 lines	0 comments	Download
D	cloud_print/service/DEPS	View		1 chunk	+0 lines, -4 lines	0 comments	Download
D	cloud_print/virtual_driver/GCP-driver.ppd	View		1 chunk	+0 lines, -62 lines	0 comments	Download
A	cloud_print/virtual_driver/gcp-driver.ppd	View		1 chunk	+62 lines, -0 lines	0 comments	Download
D	cloud_print/virtual_driver/win/install/DEPS	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	cloud_print/virtual_driver/win/install/setup.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	cloud_print/virtual_driver/win/install/virtual_driver_install.gyp	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	cloud_print/virtual_driver/win/virtual_driver.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Albert Bodenhamer

https://chromiumcodereview.appspot.com/10636063/diff/5001/chrome/tools/build/win/FILES.cfg File chrome/tools/build/win/FILES.cfg (right): https://chromiumcodereview.appspot.com/10636063/diff/5001/chrome/tools/build/win/FILES.cfg#newcode550 chrome/tools/build/win/FILES.cfg:550: 'filename': 'gcp-driver.dll', gcp-driver.ppd

8 years, 6 months ago (2012-06-26 20:42:30 UTC) #1

Vitaly Buka (NO REVIEWS)

8 years, 6 months ago (2012-06-26 20:44:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/10636063/5003

8 years, 6 months ago (2012-06-26 20:47:32 UTC) #4

Change committed as 144296

Expand Messages | Collapse Messages