Issue 10636052: Don't log to stderr when running layout tests in the content shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10636052: Don't log to stderr when running layout tests in the content shell (Closed)

Created:
8 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
jam, marja

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't log to stderr when running layout tests in the content shell BUG=111316 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144420

Patch Set 1 #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	content/shell/shell_main_delegate.cc	View		4 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

8 years, 6 months ago (2012-06-26 15:30:00 UTC) #3

lgtm

https://chromiumcodereview.appspot.com/10636052/diff/1/content/shell/shell_ma...
File content/shell/shell_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/10636052/diff/1/content/shell/shell_ma...
content/shell/shell_main_delegate.cc:37: const bool kProcessId = true;
nit: i find that naming booleans like this, instead of SetLogItems(true, true,
false, true) is basically a duplication of the documentation of SetLogItems. If
someone really cares  to know what the parameters do, they can easily look at
the header. but this is personal style, so up to you :)

Expand Messages | Collapse Messages