Issue 10636046: Make chrome compile with the win8 sdk

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10636046: Make chrome compile with the win8 sdk (Closed)

Created:
8 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
8 years, 5 months ago

Reviewers:
robertshield

CC:
chromium-reviews, grt+watch_chromium.org, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make chrome compile with the win8 sdk So we can move the metro bits to src The EXCEPTION_REGISTRATION_RECORD is now defined along with a definition of Handler. BUG=127799 TEST= it builds Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144342

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
	M	chrome_frame/crash_reporting/vectored_handler-impl.h	View	1 2	2 chunks	+7 lines, -7 lines	0 comments	Download
	M	chrome_frame/crash_reporting/veh_test.h	View	1 2 3	2 chunks	+21 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

robertshield

On 2012/06/26 04:14:37, cpu wrote: LGTM, but I think vectored_handler_tests needs updating as well to ...

8 years, 6 months ago (2012-06-26 14:25:14 UTC) #2

cpu_(ooo_6.6-7.5)

I'll review the bot failures and ping you again. thanks.

8 years, 5 months ago (2012-06-26 18:27:23 UTC) #3

cpu_(ooo_6.6-7.5)

8 years, 5 months ago (2012-06-26 22:10:08 UTC) #4

the fix was just to copy the entire definition instead of selected parts,
something inside gmock causes this. I will commit when tree opens.