Enable base::NonThreadSafe when DCHECK_ALWAYS_ON is set

Enable base::NonThreadSafe when DCHECK_ALWAYS_ON is set

Previously base::NonThreadSafe only looked at Debug builds. Also enable it
for Release builds when DCHECK_ALWAYS_ON is set (eg: the try bots &
waterfall bots)

BUG=none
TEST=existing


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144384

[Ryan Sleevi, 2012-06-25 23:10:35]

willchan: For review
+cc jam: FYI in the event of objections

Relevant Chromium-dev style/correctness thread:
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

[jam, 2012-06-26 01:56:30]

cool, I'll switch thread_restrictions to this as well.

http://codereview.chromium.org/10636044/diff/5002/base/threading/non_thread_s...
File base/threading/non_thread_safe.h (right):

http://codereview.chromium.org/10636044/diff/5002/base/threading/non_thread_s...
base/threading/non_thread_safe.h:23: // disabled) but have DCHECKs enabled at
runtime.
nit: instead of copying the comment, I would just say 
// see comment at top of thread_checker.h

[willchan no longer on Chromium, 2012-06-26 05:51:36]

lgtm

On Mon, Jun 25, 2012 at 6:56 PM, <jam@chromium.org> wrote:

> cool, I'll switch thread_restrictions to this as well.
>
>
> http://codereview.chromium.**org/10636044/diff/5002/base/**
>
threading/non_thread_safe.h<http://codereview.chromium.org/10636044/diff/5002/base/threading/non_thread_safe.h>
> File base/threading/non_thread_**safe.h (right):
>
> http://codereview.chromium.**org/10636044/diff/5002/base/**
>
threading/non_thread_safe.h#**newcode23<http://codereview.chromium.org/10636044/diff/5002/base/threading/non_thread_safe.h#newcode23>
> base/threading/non_thread_**safe.h:23: // disabled) but have DCHECKs
> enabled at runtime.
> nit: instead of copying the comment, I would just say
> // see comment at top of thread_checker.h
>
>
http://codereview.chromium.**org/10636044/<http://codereview.chromium.org/106...
>

[commit-bot: I haz the power, 2012-06-26 18:58:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10636044/9001

[commit-bot: I haz the power, 2012-06-26 18:58:35]

Failed to apply patch for base/threading/non_thread_safe.h:
While running patch -p1 --forward --force;
patching file base/threading/non_thread_safe.h
Hunk #2 FAILED at 60.
1 out of 2 hunks FAILED -- saving rejects to file
base/threading/non_thread_safe.h.rej

[commit-bot: I haz the power, 2012-06-26 19:02:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10636044/10002

[commit-bot: I haz the power, 2012-06-26 19:44:53]

Try job failure for 10636044-10002 (retry) on linux_rel for step
"base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-06-26 22:09:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10636044/17001

[commit-bot: I haz the power, 2012-06-26 23:04:52]

Try job failure for 10636044-17001 (retry) on mac_rel for step "base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-06-26 23:12:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10636044/24003

[commit-bot: I haz the power, 2012-06-27 01:40:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10636044/26002

[commit-bot: I haz the power, 2012-06-27 03:13:36]

Change committed as 144384