Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 10636039: Disable the special behaviour of document.cookie in platform apps. (Closed)

Created:
8 years, 6 months ago by Garret Kelly
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Disable the special behaviour of document.cookie in platform apps. Previously, if code within a platform app attempted to access (or override) the document.cookie field then a DOM security exception would have been raised. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/extension_webkit_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Garret Kelly
This change lets code inside of a platform app access document.cookie without causing a DOM ...
8 years, 6 months ago (2012-06-25 22:48:17 UTC) #1
miket_OOO
On 2012/06/25 22:48:17, Garret Kelly wrote: > This change lets code inside of a platform ...
8 years, 6 months ago (2012-06-25 23:22:20 UTC) #2
Mihai Parparita -not on Chrome
LGTM
8 years, 6 months ago (2012-06-25 23:31:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/10636039/1
8 years, 6 months ago (2012-06-25 23:57:35 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-26 01:39:26 UTC) #5
Change committed as 144091

Powered by Google App Engine
This is Rietveld 408576698