Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2842)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 10636017: - Fix the x64 store-barrier. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_test.cc ('k') | runtime/vm/assembler_x64_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 9049)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -1411,14 +1411,15 @@
}
+// Destroys the incoming value.
void Assembler::StoreIntoObjectFilter(Register object,
Register value,
Label* no_update) {
- andl(value, Immediate(0x5));
+ andl(value, Immediate(0x9));
shrl(value, Immediate(1));
adcl(value, object);
- andl(value, Immediate(0x7));
- cmpl(value, Immediate(0x4));
+ andl(value, Immediate(0xf));
+ cmpl(value, Immediate(0x6));
j(NOT_ZERO, no_update, Assembler::kNearJump);
}
« no previous file with comments | « runtime/vm/assembler_test.cc ('k') | runtime/vm/assembler_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698