Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: runtime/vm/stub_code_x64.cc

Issue 10636017: - Fix the x64 store-barrier. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/unit_test.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/assembler_macros.h" 9 #include "vm/assembler_macros.h"
10 #include "vm/code_generator.h" 10 #include "vm/code_generator.h"
(...skipping 1067 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 // RAX: Address being stored 1078 // RAX: Address being stored
1079 __ movq(CTX, FieldAddress(CTX, Context::isolate_offset())); 1079 __ movq(CTX, FieldAddress(CTX, Context::isolate_offset()));
1080 1080
1081 // Load top_ out of the StoreBufferBlock and add the address to the pointers_. 1081 // Load top_ out of the StoreBufferBlock and add the address to the pointers_.
1082 // RAX: Address being stored 1082 // RAX: Address being stored
1083 // CTX: Isolate 1083 // CTX: Isolate
1084 intptr_t store_buffer_offset = Isolate::store_buffer_offset(); 1084 intptr_t store_buffer_offset = Isolate::store_buffer_offset();
1085 __ movl(RBX, 1085 __ movl(RBX,
1086 Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset())); 1086 Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()));
1087 __ movq(Address(CTX, 1087 __ movq(Address(CTX,
1088 RBX, TIMES_4, 1088 RBX, TIMES_8,
1089 store_buffer_offset + StoreBufferBlock::pointers_offset()), 1089 store_buffer_offset + StoreBufferBlock::pointers_offset()),
1090 RAX); 1090 RAX);
1091 1091
1092 // Increment top_ and check for overflow. 1092 // Increment top_ and check for overflow.
1093 // RBX: top_ 1093 // RBX: top_
1094 // CTX: Isolate 1094 // CTX: Isolate
1095 Label L; 1095 Label L;
1096 __ incq(RBX); 1096 __ incq(RBX);
1097 __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()), 1097 __ movl(Address(CTX, store_buffer_offset + StoreBufferBlock::top_offset()),
1098 RBX); 1098 RBX);
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
1869 // TOS + 2: instance. 1869 // TOS + 2: instance.
1870 // TOS + 3: cache array. 1870 // TOS + 3: cache array.
1871 // Result in RCX: null -> not found, otherwise result (true or false). 1871 // Result in RCX: null -> not found, otherwise result (true or false).
1872 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) { 1872 void StubCode::GenerateSubtype3TestCacheStub(Assembler* assembler) {
1873 GenerateSubtypeNTestCacheStub(assembler, 3); 1873 GenerateSubtypeNTestCacheStub(assembler, 3);
1874 } 1874 }
1875 1875
1876 } // namespace dart 1876 } // namespace dart
1877 1877
1878 #endif // defined TARGET_ARCH_X64 1878 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/unit_test.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698